Details
Details
- Reviewers
ldionne cjdb - Group Reviewers
Restricted Project - Commits
- rGedc1f0c12c83: [libcxx][ranges] Implement indirectly_swappable.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
LGTM overall. Please don't forget iterator conformance tests!
libcxx/include/__iterator/concepts.h | ||
---|---|---|
252 | Please indicate why it's there so I don't go and move it when I forget the reason. |
Comment Actions
LGTM, but please wait for CI to be green. And perhaps give a couple hours for other reviewers to have the time to chime in. But otherwise, ship it.
(written in race condition with Chris)
Please indicate why it's there so I don't go and move it when I forget the reason.