Page MenuHomePhabricator

[libcxx][ranges] Implement indirectly_swappable.
ClosedPublic

Authored by zoecarver on Jul 1 2021, 11:59 AM.

Details

Reviewers
ldionne
cjdb
Group Reviewers
Restricted Project
Commits
rGedc1f0c12c83: [libcxx][ranges] Implement indirectly_swappable.

Diff Detail

Event Timeline

zoecarver requested review of this revision.Jul 1 2021, 11:59 AM
zoecarver created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2021, 11:59 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
cjdb added a comment.Jul 1 2021, 12:04 PM

LGTM overall. Please don't forget iterator conformance tests!

libcxx/include/__iterator/concepts.h
252

Please indicate why it's there so I don't go and move it when I forget the reason.

ldionne accepted this revision.EditedJul 1 2021, 12:05 PM

LGTM, but please wait for CI to be green. And perhaps give a couple hours for other reviewers to have the time to chime in. But otherwise, ship it.

(written in race condition with Chris)

This revision is now accepted and ready to land.Jul 1 2021, 12:05 PM
zoecarver updated this revision to Diff 355977.Jul 1 2021, 12:31 PM

Update based on Chris' feedback.

zoecarver updated this revision to Diff 356008.Jul 1 2021, 1:54 PM

Fix iterator conformance tests.

zoecarver updated this revision to Diff 356012.Jul 1 2021, 2:07 PM

Fix iterator conformance tests (again).

This revision was landed with ongoing or failed builds.Jul 1 2021, 3:08 PM
This revision was automatically updated to reflect the committed changes.