This is an archive of the discontinued LLVM Phabricator instance.

[Bazel] Update README with examples
ClosedPublic

Authored by GMNGeoffrey on Jun 30 2021, 4:12 PM.

Diff Detail

Event Timeline

GMNGeoffrey requested review of this revision.Jun 30 2021, 4:12 PM
GMNGeoffrey created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2021, 4:12 PM
chandlerc accepted this revision.Jun 30 2021, 4:28 PM

LGTM, two minor suggestions below.

utils/bazel/examples/submodule/WORKSPACE
5

This should be using a git submodule. I would guess?

8

Maybe a comment clarifying that this isn't constrained?

This revision is now accepted and ready to land.Jun 30 2021, 4:28 PM
  • Address comments
GMNGeoffrey marked 2 inline comments as done.Jun 30 2021, 4:50 PM
This revision was landed with ongoing or failed builds.Jun 30 2021, 4:50 PM
This revision was automatically updated to reflect the committed changes.