This is an archive of the discontinued LLVM Phabricator instance.

Differential D105252

[Bazel] add missing load to submodule example
ClosedPublic

Authored by GMNGeoffrey on Jun 30 2021, 6:03 PM.

Details

Reviewers
chandlerc
Commits
rGd08f8960d06a: [Bazel] add missing load to submodule example
Summary

I missed this in https://reviews.llvm.org/D105245

Diff Detail

Event Timeline

GMNGeoffrey requested review of this revision.Jun 30 2021, 6:03 PM
GMNGeoffrey created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2021, 6:03 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
chandlerc accepted this revision.Jun 30 2021, 7:19 PM

Doh, me too, sorry about that! LGTM!

utils/bazel/examples/submodule/WORKSPACE
17

Guessing buildifier will reformat this line... LGTM w/ whatever it produces though.

This revision is now accepted and ready to land.Jun 30 2021, 7:19 PM
This revision was landed with ongoing or failed builds.Jun 30 2021, 7:35 PM
Closed by commit rGd08f8960d06a: [Bazel] add missing load to submodule example (authored by GMNGeoffrey). · Explain Why
This revision was automatically updated to reflect the committed changes.
GMNGeoffrey added a commit: rGd08f8960d06a: [Bazel] add missing load to submodule example.

Revision Contents

PathSize
utils/
bazel/
examples/
submodule/
2 lines

Diff 355751

utils/bazel/examples/submodule/WORKSPACE

# This file is licensed under the Apache License v2.0 with LLVM Exceptions. # This file is licensed under the Apache License v2.0 with LLVM Exceptions.
# See https://llvm.org/LICENSE.txt for license information. # See https://llvm.org/LICENSE.txt for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
"""An example WORKSPACE for configuring LLVM using a git submodule.""" """An example WORKSPACE for configuring LLVM using a git submodule."""
workspace(name = "submodule_example") workspace(name = "submodule_example")
# Or wherever your submodule is located. # Or wherever your submodule is located.
SUBMODULE_PATH = "third_party/llvm-project" SUBMODULE_PATH = "third_party/llvm-project"
local_repository( local_repository(
name = "llvm-bazel", name = "llvm-bazel",
path = SUBMODULE_PATH + "/utils/bazel", path = SUBMODULE_PATH + "/utils/bazel",
) )
load("@llvm-bazel//:configure.bzl", "llvm_configure", "llvm_disable_optional_support_deps")
chandlercUnsubmitted
Not Done
ReplyInline Actions

Guessing buildifier will reformat this line... LGTM w/ whatever it produces though.

chandlerc: Guessing `buildifier` will reformat this line... LGTM w/ whatever it produces though.
llvm_configure( llvm_configure(
name = "llvm-project", name = "llvm-project",
src_path = SUBMODULE_PATH, src_path = SUBMODULE_PATH,
src_workspace = "@submodule_example//:WORKSPACE", src_workspace = "@submodule_example//:WORKSPACE",
) )
# Disables optional dependencies for Support like zlib and terminfo. You may # Disables optional dependencies for Support like zlib and terminfo. You may
# instead want to configure them using the macros in the corresponding bzl # instead want to configure them using the macros in the corresponding bzl
# files. # files.
llvm_disable_optional_support_deps() llvm_disable_optional_support_deps()