This is an archive of the discontinued LLVM Phabricator instance.

[Test] delete LPM RUNs in inline_nossp.ll
ClosedPublic

Authored by nickdesaulniers on Jun 29 2021, 2:58 PM.

Details

Summary

This test was modified in D104958. Invoking opt with -{passname} (vs
-passes={passname}) without -enable-new-pm={0|1} is now ambiguous and
dependent on how LLVM was configured. Drop the LPM runs rather than
fix since there unlikely to be any users still on LPM that rely on the
behavior in this test.

See also:
https://lists.llvm.org/pipermail/llvm-dev/2021-June/151553.html

Diff Detail

Event Timeline

nickdesaulniers requested review of this revision.Jun 29 2021, 2:58 PM
nickdesaulniers created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2021, 2:58 PM

Fix this test for folks still using the OPM.

I think there is no user needing legacy PM + the specific ssp inlining behavior... So I'd just delete the legacy PM tests.

nickdesaulniers retitled this revision from [Test] fix inline_nossp.ll for OPM to [Test] delete OPM RUNs in inline_nossp.ll.
nickdesaulniers edited the summary of this revision. (Show Details)
  • remove tests, update commit message
nickdesaulniers removed a subscriber: MaskRay.
  • remove line from update_test_checks that I didn't mean to commit
MaskRay accepted this revision.Jun 29 2021, 4:52 PM

Thanks!

This revision is now accepted and ready to land.Jun 29 2021, 4:52 PM
MaskRay added a comment.EditedJun 29 2021, 4:53 PM

More formal name is "legacy PM", not "old PM"

The abbreviation "OPM" may be a bit ambiguous

nickdesaulniers retitled this revision from [Test] delete OPM RUNs in inline_nossp.ll to [Test] delete LPM RUNs in inline_nossp.ll.Jun 29 2021, 5:09 PM
nickdesaulniers edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Jun 29 2021, 5:11 PM
This revision was automatically updated to reflect the committed changes.