This is an archive of the discontinued LLVM Phabricator instance.

[clang] Document llvm options controlling pragma unroll
ClosedPublic

Authored by yaxunl on Jun 28 2021, 8:25 AM.

Details

Summary

Add documentation about LLVM options for controlling pragma unroll.

Diff Detail

Event Timeline

yaxunl requested review of this revision.Jun 28 2021, 8:25 AM
yaxunl created this revision.
tra added inline comments.Jun 28 2021, 10:07 AM
clang/docs/LanguageExtensions.rst
3412

Nit: I think that "loop unrolling increases code size and, therefore, compilation time" is kind of obvious and not particularly helpful. My preference would be to remove it and just leave the details on how to control the unrolling.

3413

Considering that we're talking about clang extensions, we should probably use -mllvm -unroll-count=n.
I'd also rephrase it a bit so that "what" comes before "how". I.e. Loop unroll parameters can be controlled via -mllvm foo and -mllvm bar.

yaxunl updated this revision to Diff 356967.Jul 7 2021, 8:10 AM
yaxunl marked 2 inline comments as done.

revised by Artem's comments.

tra accepted this revision.Jul 12 2021, 11:53 AM
This revision is now accepted and ready to land.Jul 12 2021, 11:53 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2021, 1:44 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript