Details
- Reviewers
• Quuxplusone ldionne - Group Reviewers
Restricted Project - Commits
- rGf32f3db9fcbf: [libc++] Split the various iterator types out of <iterator>
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libcxx/include/__iterator/insert_iterator.h | ||
---|---|---|
11–12 | /BACK_// |
Sure, once buildkite is happy, I'm happy.
It would be a good idea — if you haven't already done so — to diff {i,o}stream_iterator.h, and diff {front,back}_insert_iterator.h, and so on; and try to remove any gratuitous differences in formatting or inclusions or anything.
libcxx/include/__iterator/wrap_iter.h | ||
---|---|---|
79–82 | I suppose this is just shuffling code around, so OK; but it would make a good followup to investigate why these 4 lines are here, and what breaks if they're removed (if anything). I suspect they're obsolete. |
Fix CI failures (hopefully).
libcxx/include/__iterator/wrap_iter.h | ||
---|---|---|
79–82 | I planned on doing that, thanks for reminding me. Those forward declarations are obsolete, I already checked that the other day. |
Note: I am expecting this to fail in the Modules build because I did not add the relevant files to the modulemap. If it doesn't fail, I'll raise an eyebrow.
The modules build doesn't fail - it's a bit suspicious, but as Arthur said in an offline conversation, it appears that those modulemap changes are only necessary when there is some sort of specialization of a type defined in another header or something like that.
/BACK_//