This is an archive of the discontinued LLVM Phabricator instance.

Differential D104585

[NFC] Add getUnderlyingObjects test
ClosedPublic

Authored by vitalybuka on Jun 18 2021, 6:35 PM.

Details

Reviewers
lebedev.ri
Commits
rGac15a128d875: [NFC] Add getUnderlyingObjects test

Diff Detail

Event Timeline

vitalybuka requested review of this revision.Jun 18 2021, 6:35 PM
vitalybuka created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2021, 6:35 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
vitalybuka updated this revision to Diff 353146.Jun 18 2021, 6:42 PM

update

vitalybuka added a child revision: D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects.Jun 18 2021, 6:44 PM
vitalybuka added a reviewer: lebedev.ri.
lebedev.ri accepted this revision.Jun 19 2021, 3:01 AM

Thank you for adding the test.
I think you can freely commit this now.

llvm/test/Analysis/LoopAccessAnalysis/underlying-objects-2.ll
98

Given D86669, i think you want to add a FIXME: this is incorrect: xyz

This revision is now accepted and ready to land.Jun 19 2021, 3:01 AM
Harbormaster completed remote builds in B110031: Diff 353146.Jun 19 2021, 1:25 PM
Closed by commit rGac15a128d875: [NFC] Add getUnderlyingObjects test (authored by vitalybuka). · Explain WhyJun 21 2021, 4:37 PM
This revision was automatically updated to reflect the committed changes.
vitalybuka added a commit: rGac15a128d875: [NFC] Add getUnderlyingObjects test.

Revision Contents

PathSize
llvm/
test/
Analysis/
LoopAccessAnalysis/
62 lines

Diff 353516

llvm/test/Analysis/LoopAccessAnalysis/underlying-objects-2.ll

Show All 31 Lines
; To illustrate one of the negative consequences of this, if the loop has a ; To illustrate one of the negative consequences of this, if the loop has a
; backward dependence we won't detect this but instead fully fall back on ; backward dependence we won't detect this but instead fully fall back on
; memchecks (that is what LAA does after encountering a case of non-constant ; memchecks (that is what LAA does after encountering a case of non-constant
; distance). ; distance).
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-apple-macosx10.10.0" target triple = "x86_64-apple-macosx10.10.0"
; CHECK-LABEL: function 'f'
; CHECK: for_j.body: ; CHECK: for_j.body:
; CHECK-NEXT: Report: unsafe dependent memory operations in loop ; CHECK-NEXT: Report: unsafe dependent memory operations in loop
; CHECK-NEXT: Dependences: ; CHECK-NEXT: Dependences:
; CHECK-NEXT: Backward: ; CHECK-NEXT: Backward:
; CHECK-NEXT: %loadB = load i8, i8* %gepB, align 1 -> ; CHECK-NEXT: %loadB = load i8, i8* %gepB, align 1 ->
; CHECK-NEXT: store i8 2, i8* %gepB_plus_one, align 1 ; CHECK-NEXT: store i8 2, i8* %gepB_plus_one, align 1
define void @f(i8** noalias %A, i8* noalias %B, i64 %N) { define void @f(i8** noalias %A, i8* noalias %B, i64 %N) {
Show All 36 Linesfor_j.end:
%i.1 = add nuw i64 %i, 1 %i.1 = add nuw i64 %i, 1
%exitcond = icmp eq i64 %i.1, %N %exitcond = icmp eq i64 %i.1, %N
br i1 %exitcond, label %for_i.end, label %for_i.body br i1 %exitcond, label %for_i.end, label %for_i.body
for_i.end: for_i.end:
ret void ret void
} }
; CHECK-LABEL: function 'f_deep'
; CHECK: for_j.body:
; FIXME: This is incorrect and is going to be fixed with D86669.
; CHECK-NEXT: Memory dependences are safe with run-time checks
; CHECK-NEXT: Dependences:
lebedev.riUnsubmitted
Not Done
ReplyInline Actions

Given D86669, i think you want to add a FIXME: this is incorrect: xyz

lebedev.ri: Given D86669, i think you want to add a `FIXME: this is incorrect: xyz`
define void @f_deep(i8** noalias %A, i8* noalias %B, i64 %N) {
for_i.preheader:
%prev_0 = load i8*, i8** %A, align 8
br label %for_i.body
for_i.body:
%i = phi i64 [1, %for_i.preheader], [%i.1, %for_j.end]
%prev = phi i8* [%prev_0, %for_i.preheader], [%curr, %for_j.end]
%gep = getelementptr inbounds i8*, i8** %A, i64 %i
%curr = load i8*, i8** %gep, align 8
br label %for_j.preheader
for_j.preheader:
br label %for_j.body
for_j.body:
%j = phi i64 [0, %for_j.preheader], [%j.1, %for_j.body]
%gepPrev = getelementptr inbounds i8, i8* %prev, i64 %j
%gepCurr = getelementptr inbounds i8, i8* %curr, i64 %j
%gepB = getelementptr inbounds i8, i8* %B, i64 %j
%gepB1 = getelementptr inbounds i8, i8* %gepB, i64 %j
%gepB2 = getelementptr inbounds i8, i8* %gepB1, i64 0
%gepB3 = getelementptr inbounds i8, i8* %gepB2, i64 0
%gepB4 = getelementptr inbounds i8, i8* %gepB3, i64 0
%gepB5 = getelementptr inbounds i8, i8* %gepB4, i64 0
%gepB6 = getelementptr inbounds i8, i8* %gepB5, i64 0
%gepB7 = getelementptr inbounds i8, i8* %gepB6, i64 0
%gepB8 = getelementptr inbounds i8, i8* %gepB7, i64 0
%gepB9 = getelementptr inbounds i8, i8* %gepB8, i64 0
%loadPrev = load i8, i8* %gepPrev, align 1
%loadB = load i8, i8* %gepB9, align 1
%mul = mul i8 %loadPrev, %loadB
store i8 %mul, i8* %gepCurr, align 1
%gepB_plus_one = getelementptr inbounds i8, i8* %gepB, i64 1
store i8 2, i8* %gepB_plus_one, align 1
%j.1 = add nuw i64 %j, 1
%exitcondj = icmp eq i64 %j.1, %N
br i1 %exitcondj, label %for_j.end, label %for_j.body
for_j.end:
%i.1 = add nuw i64 %i, 1
%exitcond = icmp eq i64 %i.1, %N
br i1 %exitcond, label %for_i.end, label %for_i.body
for_i.end:
ret void
}