Page MenuHomePhabricator
Differential D104585

[NFC] Add getUnderlyingObjects test
ClosedPublic
Actions

Authored by vitalybuka on Jun 18 2021, 6:35 PM.

Details

Reviewers
lebedev.ri
Commits
rGac15a128d875: [NFC] Add getUnderlyingObjects test

Diff Detail

Event Timeline

vitalybuka requested review of this revision.Jun 18 2021, 6:35 PM
vitalybuka created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2021, 6:35 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
vitalybuka updated this revision to Diff 353146.Jun 18 2021, 6:42 PM

update

vitalybuka added a child revision: D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects.Jun 18 2021, 6:44 PM
vitalybuka added a reviewer: lebedev.ri.
lebedev.ri accepted this revision.Jun 19 2021, 3:01 AM

Thank you for adding the test.
I think you can freely commit this now.

llvm/test/Analysis/LoopAccessAnalysis/underlying-objects-2.ll
98

Given D86669, i think you want to add a FIXME: this is incorrect: xyz

This revision is now accepted and ready to land.Jun 19 2021, 3:01 AM
Harbormaster completed remote builds in B110031: Diff 353146.Jun 19 2021, 1:25 PM
Closed by commit rGac15a128d875: [NFC] Add getUnderlyingObjects test (authored by vitalybuka). · Explain WhyJun 21 2021, 4:37 PM
This revision was automatically updated to reflect the committed changes.
vitalybuka added a commit: rGac15a128d875: [NFC] Add getUnderlyingObjects test.

Revision Contents
Changeset List

PathSize
llvm/
test/
Analysis/
LoopAccessAnalysis/
62 lines

Diff 353516

View Options

llvm/test/Analysis/LoopAccessAnalysis/underlying-objects-2.ll

Loading...