Page MenuHomePhabricator

[lldb] Remove redundant calls to set eReturnStatusFailed
ClosedPublic

Authored by DavidSpickett on Jun 16 2021, 6:35 AM.

Details

Summary

Since https://reviews.llvm.org/D103701 AppendError<...>
sets this for you.

This change includes all of the non-command uses.

Some uses remain where it's either tricky to reason about
the logic, or they aren't paired with AppendError calls.

Diff Detail

Event Timeline

DavidSpickett requested review of this revision.Jun 16 2021, 6:35 AM
DavidSpickett created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2021, 6:35 AM

There'll be a part 2 once this has passed the bots, which will cover all the CommandObject* files.

DavidSpickett added inline comments.
lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
835

https://reviews.llvm.org/D104380 should address calls like this one. Where we append something that could be empty.

teemperor accepted this revision.Jun 16 2021, 8:30 AM

LGTM and passes on macOS and Linux for me. Thanks!

This revision is now accepted and ready to land.Jun 16 2021, 8:30 AM