This is an archive of the discontinued LLVM Phabricator instance.

Differential D104311

[clang] Fix a race condition in the build of clangInterpreter
ClosedPublic

Authored by stella.stamenova on Jun 15 2021, 10:08 AM.

Details

Reviewers
v.g.vassilev
Commits
rG734d688fbce8: [clang] Fix a race condition in the build of clangInterpreter
Summary

The library depends on Attributes.inc, so it has to depend on the intrinsics_gen target

Diff Detail

Event Timeline

stella.stamenova created this revision.Jun 15 2021, 10:08 AM
Herald added a subscriber: mgorny. · View Herald TranscriptJun 15 2021, 10:08 AM
stella.stamenova requested review of this revision.Jun 15 2021, 10:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2021, 10:08 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B109322: Diff 352173.Jun 15 2021, 12:54 PM
v.g.vassilev accepted this revision.Jun 17 2021, 3:12 AM

Thanks, @stella.stamenova!

This revision is now accepted and ready to land.Jun 17 2021, 3:12 AM
Closed by commit rG734d688fbce8: [clang] Fix a race condition in the build of clangInterpreter (authored by stella.stamenova). · Explain WhyJun 17 2021, 10:03 AM
This revision was automatically updated to reflect the committed changes.
stella.stamenova added a commit: rG734d688fbce8: [clang] Fix a race condition in the build of clangInterpreter.

Revision Contents

PathSize
clang/
lib/
Interpreter/
3 lines

Diff 352775

clang/lib/Interpreter/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
core core
native native
Option Option
OrcJit OrcJit
Support Support
Target Target
) )
add_clang_library(clangInterpreter add_clang_library(clangInterpreter
IncrementalExecutor.cpp IncrementalExecutor.cpp
IncrementalParser.cpp IncrementalParser.cpp
Interpreter.cpp Interpreter.cpp
DEPENDS
intrinsics_gen
LINK_LIBS LINK_LIBS
clangAST clangAST
clangAnalysis clangAnalysis
clangBasic clangBasic
clangDriver clangDriver
clangEdit clangEdit
clangFrontend clangFrontend
clangLex clangLex
clangParse clangParse
clangSema clangSema
clangSerialization clangSerialization
clangCodeGen clangCodeGen
clangFrontendTool clangFrontendTool
) )