Page MenuHomePhabricator

[libc++] NFC: Move indirect_concepts.h to __iterator/concepts.h
ClosedPublic

Authored by ldionne on Jun 10 2021, 10:43 AM.

Details

Summary

There's no fundamental reason to separate those from the other iterator
concepts.

Diff Detail

Event Timeline

ldionne created this revision.Jun 10 2021, 10:43 AM
ldionne requested review of this revision.Jun 10 2021, 10:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2021, 10:43 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Quuxplusone accepted this revision.Jun 10 2021, 7:20 PM
Quuxplusone added a subscriber: Quuxplusone.

LGTM. But btw, what's going on with these GCC failures? I thought you (@ldionne) were going to fix them, but it's been like a month now. Should I make a PR for it? Some of these failures are just straight up typos in the test cases; others might require some digging, I don't know (which is why I was happy to let you deal with it, I thought).

This revision is now accepted and ready to land.Jun 10 2021, 7:20 PM

LGTM. But btw, what's going on with these GCC failures? I thought you (@ldionne) were going to fix them, but it's been like a month now. Should I make a PR for it? Some of these failures are just straight up typos in the test cases; others might require some digging, I don't know (which is why I was happy to let you deal with it, I thought).

There's been a lot going on in the past few weeks (notably with CI failures) and I have not had time to finish that up yet. Feel free to pick it up if you want (but don't touch the ranges::prev/ranges::next failures since I have a patch for that I'm finishing up).