This is an archive of the discontinued LLVM Phabricator instance.

[flang] Fixed simple typo in runtime code
ClosedPublic

Authored by zacharyselk on Jun 10 2021, 7:40 AM.

Diff Detail

Event Timeline

zacharyselk requested review of this revision.Jun 10 2021, 7:40 AM
zacharyselk created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2021, 7:40 AM
klausler accepted this revision.Jun 10 2021, 8:16 AM

LGTM; thank you.

This revision is now accepted and ready to land.Jun 10 2021, 8:16 AM
This revision was automatically updated to reflect the committed changes.
jrtc27 added a subscriber: jrtc27.EditedJan 17 2022, 2:53 PM

This was committed with the author email set to the empty string. Git seems happy enough to create it (though I suspect it shouts at you still), but rebasing chokes with:

fatal: empty ident name (for <Zachary Selk>) not allowed

Arguably this inconsistency is a bug in Git, but at the same time the commit was bogus. I see also your most recent commit, https://reviews.llvm.org/rZORG5a4757532b3e92a287cce159739e36717b7ab682, is similarly missing an author email. Can you please make sure you've fixed your config so this never happens again (thankfully only a single such broken commit was to llvm-project)? It is a real pain to deal with in our workflow as it totally breaks git-subrepo (https://github.com/ingydotnet/git-subrepo), at least when used in rebase mode.

Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2022, 2:53 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript

Oh I did not notice that! Thank you for pointing it out, I will definitely fix my config!