This is an archive of the discontinued LLVM Phabricator instance.

[lld/mac] Make framework symlinks in tests more realistic
ClosedPublic

Authored by thakis on Jun 9 2021, 5:31 PM.

Details

Reviewers
gkm
int3
Group Reviewers
Restricted Project
Commits
rGbbe6f51b726f: [lld/mac] Make framework symlinks in tests more realistic
Summary

In a framework Foo.framework, Foo.framework/Foo is usually a relative
symbolic link to Foo.framework/Versions/Current/Foo,
and Foo.framework/Versions/Current is usually a relative symbolic
link to A.

Our tests used absolute symbolic links. Now they use relative symbolic links.

No behavior change, just makes the tests more representative of the real world.

(implicit-dylib.s omits the "Current" folder too, but I'm not changing that
here.)

Diff Detail

Event Timeline

thakis created this revision.Jun 9 2021, 5:31 PM
Herald added a project: Restricted Project. · View Herald Transcript
thakis requested review of this revision.Jun 9 2021, 5:31 PM
int3 accepted this revision.Jun 9 2021, 5:37 PM
int3 added a subscriber: int3.

Realism is always good :)

This revision is now accepted and ready to land.Jun 9 2021, 5:37 PM
This revision was landed with ongoing or failed builds.Jun 9 2021, 5:40 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2021, 5:40 PM