[scudo] Remove ScopedString::Length

[vitalybuka]

Fix CHECK

[cryptoad]

compiler-rt/lib/scudo/standalone/string_utils.cpp

231

Maybe Length instead of length() since we just stored it in a variable?

compiler-rt/lib/scudo/standalone/string_utils.h

 
 #include <stdarg.h>
 
 namespace scudo {
 
 class ScopedString {
 public:
   explicit ScopedString() { String.push_back('\0'); }
-  uptr length() { return Length; }
+  uptr length() { return String.size() - 1; }
   const char *data() { return String.data(); }
   void clear() {
     String.clear();
     String.push_back('\0');
-    Length = 0;
   }
   void append(const char *Format, va_list Args);
   void append(const char *Format, ...);
   void output() const { outputRaw(String.data()); }
 
 private:
   Vector<char> String;
-  uptr Length = 0;
 };
 
 int formatString(char *Buffer, uptr BufferLength, const char *Format, ...);
 void Printf(const char *Format, ...);
 
 } // namespace scudo
 
 #endif // SCUDO_STRING_UTILS_H_

compiler-rt/lib/scudo/standalone/string_utils.cpp

int formatString(char *Buffer, uptr BufferLength, const char *Format, ...) {
   va_list Args;
   va_start(Args, Format);
   int Res = formatString(Buffer, BufferLength, Format, Args);
   va_end(Args);
   return Res;
 }
 
 void ScopedString::append(const char *Format, va_list Args) {
-  RAW_CHECK(Length <= String.size());
   va_list ArgsCopy;
   va_copy(ArgsCopy, Args);
   // formatString doesn't currently support a null buffer or zero buffer length,
   // so in order to get the resulting formatted string length, we use a one-char
   // buffer.
   char C[1];
   const uptr AdditionalLength =
       static_cast<uptr>(formatString(C, sizeof(C), Format, Args)) + 1;
-  String.resize(Length + AdditionalLength);
-  formatString(String.data() + Length, AdditionalLength, Format, ArgsCopy);
+  const uptr Length = length();
+  String.resize(length() + AdditionalLength);
+  const uptr AddedLength = static_cast<uptr>(formatString(
+      String.data() + Length, String.size() - Length, Format, ArgsCopy));
+  RAW_CHECK(data()[length()] == '\0');
+  RAW_CHECK(AddedLength == AdditionalLength);
   va_end(ArgsCopy);
-  Length = strlen(String.data());
-  RAW_CHECK(Length < String.size());
 }
 
 FORMAT(2, 3)
 void ScopedString::append(const char *Format, ...) {
   va_list Args;
   va_start(Args, Format);
   append(Format, Args);
   va_end(Args);