Page MenuHomePhabricator

[flang] CheckConformance: tristate-ify result
ClosedPublic

Authored by klausler on Jun 3 2021, 3:55 PM.

Details

Summary

To ensure that errors are emitted by CheckConformance and
its callers in all situations, it's necessary for the returned result
of that function to distinguish between three possible
outcomes: the arrays are known to conform at compilation time,
the arrays are known to not conform (and a message has been
produced), and an indeterminate result in which is not possible
to determine conformance. So convert CheckConformance's
result into an optional<bool>, and convert its confusing
Boolean flag arguments into a bit-set of named flags too.

Diff Detail

Event Timeline

klausler created this revision.Jun 3 2021, 3:55 PM
klausler requested review of this revision.Jun 3 2021, 3:55 PM
This revision is now accepted and ready to land.Jun 4 2021, 5:40 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2021, 11:19 AM