This is an archive of the discontinued LLVM Phabricator instance.

Differential D103623

[Clang] Test case for -Wunused-but-set-variable, warn for volatile.
ClosedPublic

Authored by mbenfield on Jun 3 2021, 8:54 AM.

Details

Reviewers
sberg
Commits
rG20f7b5f3f9c8: [Clang] Test case for -Wunused-but-set-variable, warn for volatile.
Summary

This was requested by sberg.

Diff Detail

Unit TestsFailed

TimeTest
11,160 msx64 debian > libarcher.races::lock-unrelated.c

Event Timeline

mbenfield requested review of this revision.Jun 3 2021, 8:54 AM
mbenfield created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2021, 8:54 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B107465: Diff 349567.Jun 3 2021, 9:41 AM
sberg accepted this revision.Jun 9 2021, 5:33 AM

LGTM

This revision is now accepted and ready to land.Jun 9 2021, 5:33 AM
mbenfield updated this revision to Diff 351563.Jun 11 2021, 2:16 PM

rebase and rerun builds

Harbormaster completed remote builds in B108898: Diff 351563.Jun 11 2021, 3:17 PM
Closed by commit rG20f7b5f3f9c8: [Clang] Test case for -Wunused-but-set-variable, warn for volatile. (authored by mbenfield, committed by george.burgess.iv). · Explain WhyJun 14 2021, 10:27 AM
This revision was automatically updated to reflect the committed changes.
george.burgess.iv added a commit: rG20f7b5f3f9c8: [Clang] Test case for -Wunused-but-set-variable, warn for volatile..

Revision Contents

PathSize
clang/
test/
Sema/
4 lines

Diff 349567

clang/test/Sema/warn-unused-but-set-variables.c

Show All 17 Linesint f0() {
// Don't warn for an extern variable. // Don't warn for an extern variable.
extern int w; extern int w;
w = 0; w = 0;
// Following gcc, this should not warn. // Following gcc, this should not warn.
int a; int a;
w = (a = 0); w = (a = 0);
// Following gcc, warn for a volatile variable.
volatile int b; // expected-warning{{variable 'b' set but not used}}
b = 0;
int x; int x;
x = 0; x = 0;
return x; return x;
} }
void f1(void) { void f1(void) {
(void)^() { (void)^() {
int y; // expected-warning{{variable 'y' set but not used}} int y; // expected-warning{{variable 'y' set but not used}}
Show All 14 Lines