- Added emulation of MIPS64 floating-point branch instructions
- Updated GetRegisterInfo to recognize floating-point registers
- Provided CPU information while creating createMCSubtargetInfo in disassembler
- Bug fix in emulation of JIC and JIALC
- Correct identification of breakpoint when set in a delay slot of a branch instruction
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp | ||
---|---|---|
640 ↗ | (On Diff #27427) | Initialize this with "" for now and then remove the setting to "" in the default. Just in case someone later adds code and doesn't set cpu to something. |
source/Plugins/Process/Linux/NativeProcessLinux.cpp | ||
3487–3505 ↗ | (On Diff #27427) | This should probably be moved somewhere more generic so that this code doesn't get duplicated for each process plug-in. |
Comment Actions
Thanks for the comments.
source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp | ||
---|---|---|
640 ↗ | (On Diff #27427) | We would still need cpu = "" in the default case to avoid -Wswitch warning. |
source/Plugins/Process/Linux/NativeProcessLinux.cpp | ||
3487–3505 ↗ | (On Diff #27427) | We will remove it from this patch and submit a separate patch. |
source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp | ||
---|---|---|
640–678 ↗ | (On Diff #27752) | Is CPU needed here? We are passing the triple which should contain the CPU name right? Why do we need "cpu" here as a separate thing? |
source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp | ||
---|---|---|
640–678 ↗ | (On Diff #27752) | The triple does not contain MIPS ISA revision (like r2, r3, r5, r6 etc.) which is required for disassembly. |