Page MenuHomePhabricator

[lldb] Fix typos.
ClosedPublic

Authored by brucem on Sun, May 30, 7:16 AM.

Diff Detail

Event Timeline

brucem created this revision.Sun, May 30, 7:16 AM
brucem requested review of this revision.Sun, May 30, 7:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptSun, May 30, 7:16 AM
teemperor accepted this revision.Sun, May 30, 12:33 PM
teemperor added a subscriber: teemperor.

LGTM but could you split out the non-NFC change (and then you can also mark this whole commit as NFC). I'm just going to accept this module that change.

lldb/source/API/SBDebugger.cpp
164

Can you clang-format and move this into its own patch (it's not really a NFC typo).

This revision is now accepted and ready to land.Sun, May 30, 12:33 PM
brucem updated this revision to Diff 348713.Sun, May 30, 4:47 PM

Remove incorrect change.

brucem updated this revision to Diff 348714.Sun, May 30, 4:49 PM

Mark as NFC.

I assume you don't have requested commit access yet (?) so I'm going to land this for you. Thanks for the patch!

This revision was landed with ongoing or failed builds.Sun, May 30, 5:30 PM
Closed by commit rG36597e4719e9: [lldb] Fix typos. NFC. (authored by brucem). · Explain Why
This revision was automatically updated to reflect the committed changes.

I had requested it and got it a short bit ago. Looks like I landed it successfully. Thanks for the review!