This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Add missing reproducer instrumentation to some SB classes
Needs RevisionPublic

Authored by teemperor on May 31 2021, 1:56 AM.

Details

Summary

I noticed that there might be some missing instrumentation after a related change popped up in D103381.
This patch is just the result of running lldb-instr over the different parts of the SB API implementations (+ some manual filtering).

Diff Detail

Event Timeline

teemperor requested review of this revision.May 31 2021, 1:56 AM
teemperor created this revision.
brucem added a subscriber: brucem.May 31 2021, 3:04 AM
brucem added inline comments.
lldb/source/API/SBDebugger.cpp
165

This one is already present in the function but near the end of the function due to our parameters.

This revision is now accepted and ready to land.Jun 11 2021, 10:49 AM
brucem requested changes to this revision.Jun 11 2021, 9:11 PM

The change to SBDebugger::GetProgressFromEvent needs to be removed.

This revision now requires changes to proceed.Jun 11 2021, 9:11 PM