Page MenuHomePhabricator

[lldb/API] Expose triple for SBProcessInfo.
ClosedPublic

Authored by brucem on Sun, May 30, 3:36 AM.

Details

Summary

This is present when doing a platform process list and is
tracked by the underlying code. To do something like the
process list via the SB API in the future, this must be
exposed.

Diff Detail

Event Timeline

brucem requested review of this revision.Sun, May 30, 3:36 AM
brucem created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSun, May 30, 3:36 AM
teemperor added inline comments.
lldb/source/API/SBProcessInfo.cpp
191

You need to 'instrument' these functions. there is a tool called lldb-instr you can build withint LLDB and you can run that over the file to generate the macro stuff for you.

teemperor removed subscribers: teemperor, JDevlieghere.
brucem added inline comments.Sun, May 30, 4:49 AM
lldb/source/API/SBProcessInfo.cpp
191

This has the LLDB_RECORD_METHOD_NO_ARGS already and is the same as the other methods in this file. (And it calls LLDB_REGISTER_METHOD as well...)

teemperor added inline comments.Sun, May 30, 4:59 AM
lldb/source/API/SBProcessInfo.cpp
191

My bad, I thought that we needed to put const char * inside a LLDB_RECORD_RESULT but apparently that's not the case (at least lldb-instr says it's not the case).

clayborg accepted this revision.Tue, Jun 1, 3:56 PM
clayborg added a subscriber: clayborg.

LGTM

This revision is now accepted and ready to land.Tue, Jun 1, 3:56 PM
This revision was landed with ongoing or failed builds.Tue, Jun 1, 9:35 PM
This revision was automatically updated to reflect the committed changes.