This is an archive of the discontinued LLVM Phabricator instance.

[RS4GC] Add a test to demonstrate duplication of base generation. NFC
ClosedPublic

Authored by yrouban on May 27 2021, 3:58 AM.

Details

Summary

This new test demonstrates a case where a base ptr is generated twice for the same value: the first one is generated while the gc.get.pointer.base() is inlined, the second is generated for the statepoint. This happens because the methods inlineGetBaseAndOffset() and insertParsePoints() do not share their defining value cache used by the findBasePointer() method.

Diff Detail

Event Timeline

yrouban requested review of this revision.May 27 2021, 3:58 AM
yrouban created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2021, 3:58 AM
reames accepted this revision.Jun 21 2021, 10:37 AM

LGTM.

p.s. This could have landed without review.

This revision is now accepted and ready to land.Jun 21 2021, 10:37 AM
This revision was landed with ongoing or failed builds.Jul 12 2021, 4:13 AM
This revision was automatically updated to reflect the committed changes.