Page MenuHomePhabricator

[CSSPGO][llvm-profgen] Change default cold threshold for context merging
ClosedPublic

Authored by wenlei on May 24 2021, 9:32 PM.

Details

Summary

llvm-profgen uses profile summary based cold threshold to merge and trim cold context profile. This is to strike a good balance between profile size and performance.

We've been using 99.9% as the cutoff to save profile size without affecting performance. This change switch to use 99.9% instead of 99.9999% as default cold threshold cutoff for llvm-profgen.

Redundant switch csprof-cold-thres is also removed and tests cleaned up.

Diff Detail

Event Timeline

wenlei created this revision.May 24 2021, 9:32 PM
wenlei requested review of this revision.May 24 2021, 9:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2021, 9:32 PM
wmi accepted this revision.May 25 2021, 9:42 AM

LGTM.

This revision is now accepted and ready to land.May 25 2021, 9:42 AM
hoy accepted this revision.May 25 2021, 9:47 AM
wlei accepted this revision.May 25 2021, 9:48 AM

LGTM, thanks!

This revision was landed with ongoing or failed builds.May 25 2021, 10:41 AM
This revision was automatically updated to reflect the committed changes.