[Orc][C-bindings] remove LLVMOrcJITTargetMachineBuilderDisposeTargetTriple in favor of LLVMDisposeMessage

[supergrecko]

Summary

The implementation and intent behind freeing the triple string here is the same as LLVMGetDefaultTargetTriple (and any other owned c string returned from the C API), so we should use LLVMDisposeMessage for to free the string for consistency.

[lhames]

LGTM.

llvm/include/llvm-c/Orc.h

  */
 void LLVMOrcDisposeJITTargetMachineBuilder(
     LLVMOrcJITTargetMachineBuilderRef JTMB);
 
 /**
  * Returns the target triple for the given JITTargetMachineBuilder as a string.
  *
  * The caller owns the resulting string as must dispose of it by calling
- * LLVMOrcJITTargetMachineBuilderDisposeTargetTriple.
+ * LLVMDisposeMessage
  */
 char *LLVMOrcJITTargetMachineBuilderGetTargetTriple(
     LLVMOrcJITTargetMachineBuilderRef JTMB);
 
 /**
  * Sets the target triple for the given JITTargetMachineBuilder to the given
  * string.
  */
 void LLVMOrcJITTargetMachineBuilderSetTargetTriple(
     LLVMOrcJITTargetMachineBuilderRef JTMB, const char *TargetTriple);
 
 /**
- * Destroy a triple string returned by
- * LLVMOrcJITTargetMachineBuilderGetTargetTriple.
- */
-void LLVMOrcJITTargetMachineBuilderDisposeTargetTriple(
-    LLVMOrcJITTargetMachineBuilderRef JTMB, char *TargetTriple);
-
-/**
  * Add an object to an ObjectLayer to the given JITDylib.
  *
  * Adds a buffer representing an object file to the given JITDylib using the
  * given ObjectLayer instance. This operation transfers ownership of the buffer
  * to the ObjectLayer instance. The buffer should not be disposed of or
  * referenced once this function returns.
  *
  * Resources associated with the given object will be tracked by the given

llvm/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp

char *LLVMOrcJITTargetMachineBuilderGetTargetTriple(
   return TargetTriple;
 }
 
 void LLVMOrcJITTargetMachineBuilderSetTargetTriple(
     LLVMOrcJITTargetMachineBuilderRef JTMB, const char *TargetTriple) {
   unwrap(JTMB)->getTargetTriple() = Triple(TargetTriple);
 }
 
-void LLVMOrcJITTargetMachineBuilderDisposeTargetTriple(
-    LLVMOrcJITTargetMachineBuilderRef JTMB, char *TargetTriple) {
-  free(TargetTriple);
-}
-
 LLVMErrorRef LLVMOrcObjectLayerAddObjectFile(LLVMOrcObjectLayerRef ObjLayer,
                                              LLVMOrcJITDylibRef JD,
                                              LLVMMemoryBufferRef ObjBuffer) {
   return wrap(unwrap(ObjLayer)->add(
       *unwrap(JD), std::unique_ptr<MemoryBuffer>(unwrap(ObjBuffer))));
 }
 
 LLVMErrorRef LLVMOrcLLJITAddObjectFileWithRT(LLVMOrcObjectLayerRef ObjLayer,

llvm/unittests/ExecutionEngine/Orc/OrcCAPITest.cpp

if (LLVMErrorRef E = LLVMOrcJITTargetMachineBuilderDetectHost(&JTMB)) {
       return;
     }
 
     // Capture the target triple. We'll use it for both verification that
     // this target is *supposed* to be supported, and error messages in
     // the case that it fails anyway.
     char *TT = LLVMOrcJITTargetMachineBuilderGetTargetTriple(JTMB);
     TargetTriple = TT;
-    LLVMOrcJITTargetMachineBuilderDisposeTargetTriple(JTMB, TT);
+    LLVMDisposeMessage(TT);
 
     if (!isSupported(TargetTriple)) {
       // If this triple isn't supported then bail out.
       TargetSupported = false;
       LLVMOrcDisposeJITTargetMachineBuilder(JTMB);
       return;
     }