Page MenuHomePhabricator

[PDB] Check the type server guid when ghashing
ClosedPublic

Authored by rnk on May 20 2021, 4:23 PM.

Details

Summary

Previously we simply didn't check this. Prereq to make the test suite
pass with ghash enabled by default.

Diff Detail

Event Timeline

rnk requested review of this revision.May 20 2021, 4:23 PM
rnk created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2021, 4:23 PM
rnk updated this revision to Diff 346884.May 20 2021, 4:24 PM
  • remove whitespace change
aganea accepted this revision.May 20 2021, 4:31 PM

LTGM.

If you're making /DEBUG:GHASH the default, can we switch back to the "classic" merging?

This revision is now accepted and ready to land.May 20 2021, 4:31 PM
This revision was landed with ongoing or failed builds.May 20 2021, 4:36 PM
This revision was automatically updated to reflect the committed changes.
rnk added a comment.May 20 2021, 4:36 PM

LTGM.

If you're making /DEBUG:GHASH the default, can we switch back to the "classic" merging?

Yep, that's the plan. I was going to spell it /DEBUG:GHASH-, but that's kind of arbitrary. The other obvious option is noghash.