This is an archive of the discontinued LLVM Phabricator instance.

Differential D102654

[DebugInfo][test] Check specific func name to ignore codegen differences
ClosedPublic

Authored by jsji on May 17 2021, 2:23 PM.

Details

Reviewers
dblaikie
shchenz
Group Reviewers
Restricted Project
Commits
rG7d6449322ecb: [DebugInfo][test] Check specific func name to ignore codegen differences
Summary

We use CHECK-LABEL: define to divide input stream into functions,
this works well on most platforms.

But there are cases that some platforms (eg: AIX) may have different
codegen , especially for global constructor and descructors.

On AIX, the codegen will have two more functions: dtor_b,
finalize_b, which will fail the test.

The fix is to use specific function name so that we can safely ignore
those unrelated codegen differences.

Diff Detail

Event Timeline

jsji requested review of this revision.May 17 2021, 2:23 PM
jsji created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2021, 2:23 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B104908: Diff 345995.May 17 2021, 3:07 PM
dblaikie added inline comments.May 17 2021, 3:18 PM
clang/test/CodeGenCXX/debug-info-line.cpp
149

Probably flesh that out a bit. Maybe define{{.*}}f11?

jsji updated this revision to Diff 346011.May 17 2021, 4:08 PM

Address comments.

jsji marked an inline comment as done.May 17 2021, 4:08 PM
jsji added inline comments.
clang/test/CodeGenCXX/debug-info-line.cpp
149

Good idea.

Harbormaster completed remote builds in B104916: Diff 346011.May 17 2021, 4:40 PM
dblaikie accepted this revision.May 17 2021, 8:36 PM

Looks good, thanks!

This revision is now accepted and ready to land.May 17 2021, 8:36 PM
Closed by commit rG7d6449322ecb: [DebugInfo][test] Check specific func name to ignore codegen differences (authored by jsji). · Explain WhyMay 18 2021, 7:03 AM
This revision was automatically updated to reflect the committed changes.
jsji marked an inline comment as done.
jsji added a commit: rG7d6449322ecb: [DebugInfo][test] Check specific func name to ignore codegen differences.

Revision Contents

PathSize
clang/
test/
CodeGenCXX/
2 lines

Diff 346168

clang/test/CodeGenCXX/debug-info-line.cpp

Show First 20 Lines • Show All 140 Lines • ▼ Show 20 Lines
// CHECK: invoke{{ }} // CHECK: invoke{{ }}
// CHECK: invoke{{ }} // CHECK: invoke{{ }}
// CHECK: to label {{.*}}, !dbg [[DBG_GLBL_DTOR_B:!.*]] // CHECK: to label {{.*}}, !dbg [[DBG_GLBL_DTOR_B:!.*]]
#line 1200 #line 1200
bar b[1] = { // bar b[1] = { //
(fn(), // (fn(), //
bar())}; bar())};
// CHECK-LABEL: define // CHECK-LABEL: define{{.*}}f11
dblaikieUnsubmitted
Done
ReplyInline Actions

Probably flesh that out a bit. Maybe define{{.*}}f11?

dblaikie: Probably flesh that out a bit. Maybe `define{{.*}}f11`?
jsjiAuthorUnsubmitted
Done
ReplyInline Actions

Good idea.

jsji: Good idea.
__complex double f11() { __complex double f11() {
__complex double f; __complex double f;
// CHECK: store {{.*}} !dbg [[DBG_F11:!.*]] // CHECK: store {{.*}} !dbg [[DBG_F11:!.*]]
#line 1300 #line 1300
return f; return f;
} }
// CHECK-LABEL: define // CHECK-LABEL: define
▲ Show 20 Lines • Show All 174 Lines • Show Last 20 Lines