This is an archive of the discontinued LLVM Phabricator instance.

Differential D102485

Move FunctionInfo in addFunctionInfo rather than copying.
ClosedPublic

Authored by simon.giesecke on May 14 2021, 5:17 AM.

Download Raw Diff

Details

Reviewers

Commits

rG4ea4d9c066b6: Move FunctionInfo in addFunctionInfo rather than copying.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

simon.giesecke created this revision.May 14 2021, 5:17 AM

Herald added a subscriber: hiraditya. · View Herald TranscriptMay 14 2021, 5:17 AM

simon.giesecke requested review of this revision.May 14 2021, 5:17 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2021, 5:17 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

simon.giesecke added a parent revision: D102484: Avoid calculating the string hash twice in GsymCreator::insertString..May 14 2021, 5:17 AM

simon.giesecke added a child revision: D102486: Use a non-recursive mutex in GsymCreator..

Harbormaster completed remote builds in B104473: Diff 345405.May 14 2021, 6:13 AM

clayborg accepted this revision.May 14 2021, 2:54 PM

This revision is now accepted and ready to land.May 14 2021, 2:54 PM

Update using arc

Harbormaster completed remote builds in B104973: Diff 346098.May 18 2021, 4:18 AM

Closed by commit rG4ea4d9c066b6: Move FunctionInfo in addFunctionInfo rather than copying. (authored by simon.giesecke). · Explain WhyMay 19 2021, 3:33 AM

This revision was automatically updated to reflect the committed changes.

simon.giesecke added a commit: rG4ea4d9c066b6: Move FunctionInfo in addFunctionInfo rather than copying..

Revision Contents

Path

Size

llvm/

lib/

DebugInfo/

GSYM/

GsymCreator.cpp

2 lines

Diff 346385

llvm/lib/DebugInfo/GSYM/GsymCreator.cpp

	Show First 20 Lines • Show All 308 Lines • ▼ Show 20 Lines		if (!StrTab.contains(CHStr))
	CHStr.hash()};			CHStr.hash()};
	}			}
	return StrTab.add(CHStr);			return StrTab.add(CHStr);
	}			}

	void GsymCreator::addFunctionInfo(FunctionInfo &&FI) {			void GsymCreator::addFunctionInfo(FunctionInfo &&FI) {
	std::lock_guard<std::recursive_mutex> Guard(Mutex);			std::lock_guard<std::recursive_mutex> Guard(Mutex);
	Ranges.insert(FI.Range);			Ranges.insert(FI.Range);
	Funcs.emplace_back(FI);			Funcs.emplace_back(std::move(FI));
	}			}

	void GsymCreator::forEachFunctionInfo(			void GsymCreator::forEachFunctionInfo(
	std::function<bool(FunctionInfo &)> const &Callback) {			std::function<bool(FunctionInfo &)> const &Callback) {
	std::lock_guard<std::recursive_mutex> Guard(Mutex);			std::lock_guard<std::recursive_mutex> Guard(Mutex);
	for (auto &FI : Funcs) {			for (auto &FI : Funcs) {
	if (!Callback(FI))			if (!Callback(FI))
	break;			break;
	Show All 27 Lines