This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Enable tests for the experimental library by default
ClosedPublic

Authored by ldionne on May 8 2021, 9:05 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Restricted Project
Restricted Project
Commits
rG875ff8e059b7: [libc++] Enable tests for the experimental library by default
Summary

This matches the fact that we build the experimental library by default.
Otherwise, by default we'd be building the library but not testing it,
which is inconsistent.

Diff Detail

Event Timeline

ldionne created this revision.May 8 2021, 9:05 AM
ldionne requested review of this revision.May 8 2021, 9:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 8 2021, 9:05 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 347074.May 21 2021, 10:17 AM

Try to fix libc++abi's and libunwind's builds

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 21 2021, 10:17 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 349108.Jun 1 2021, 3:01 PM

Fix tests against the static library with libc++experimental enabled.

ldionne accepted this revision.Jun 2 2021, 9:31 AM

Tests for the static library were fixed and tested locally, shipping now.

ldionne updated this revision to Diff 349305.Jun 2 2021, 9:39 AM

Rebase onto main.

Only failure is the known Runtimes build failure that we're fixing in D103533 -- shipping.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 2 2021, 3:39 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.