This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Move -print-runtime-dir and -print-resource-dir tests
ClosedPublic

Authored by phosek on May 3 2021, 10:07 PM.

Details

Summary

Put these into a separate files to match other -print-* options tests.

Diff Detail

Event Timeline

phosek requested review of this revision.May 3 2021, 10:07 PM
phosek created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2021, 10:07 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay added inline comments.May 4 2021, 12:11 AM
clang/test/Driver/print-resource-dir.c
2

This isn't very useful. You can specify -resource-dir and check the output.

phosek updated this revision to Diff 342950.May 4 2021, 10:09 PM
phosek marked an inline comment as done.
MaskRay added inline comments.May 4 2021, 10:41 PM
clang/test/Driver/print-resource-dir.c
3

You can use -DFILE=%S/Inputs/resource-dir and check that the printed string is exactly [[FILE]].

Just use / and let Harbomaster confirm that Windows doesn't need backslash.

phosek updated this revision to Diff 342954.May 4 2021, 11:30 PM
phosek marked an inline comment as done.
phosek added inline comments.May 5 2021, 2:07 PM
clang/test/Driver/print-resource-dir.c
3

Thanks for the suggestion.

MaskRay accepted this revision.May 5 2021, 2:15 PM

Thanks!

This revision is now accepted and ready to land.May 5 2021, 2:15 PM