Page MenuHomePhabricator

[libc] warns about missing linting only in full build mode
ClosedPublic

Authored by gchatelet on Apr 30 2021, 2:40 AM.

Diff Detail

Event Timeline

gchatelet created this revision.Apr 30 2021, 2:40 AM
gchatelet requested review of this revision.Apr 30 2021, 2:40 AM
sivachandra accepted this revision.Apr 30 2021, 9:49 AM

LGTM with one additional suggestion.

libc/CMakeLists.txt
47–50

May be add something like this below this line:

if(LLVM_LIBC_ENABLE_LINTING AND (NOT LLVM_LIBC_FULL_BUILD))
  message(FATAL_ERROR "Cannot enable linting when full libc build is not enabled.")
endif()

Linting, as implemented currently, is meaningless when not using LLVM libc headers.

This revision is now accepted and ready to land.Apr 30 2021, 9:49 AM
gchatelet updated this revision to Diff 342329.May 3 2021, 1:38 AM
  • Add error when linting is ON but full build is disabled.
This revision was landed with ongoing or failed builds.May 3 2021, 1:39 AM
This revision was automatically updated to reflect the committed changes.

This causes at least one builder to fail so it's probably is misconfiguration
https://lab.llvm.org/buildbot/#/builders/138/builds/4406