Page MenuHomePhabricator

clang: Update comments on another libstdc++ HACK
ClosedPublic

Authored by urnathan on Apr 29 2021, 6:25 AM.

Details

Summary

This is another workaround for a libstdc++ problem. Both the g++ bug and libstdc++ use of it are fixed in 4.9.0, but present in the 4.8 series. So we can't remove it yet. I also verified, that when the hack is disabled, that g++ 4.9.0 gives the expected diagnostics about types not matching on the testcase Richard added for this hack.

So updating the comment with dates and version numbers..

Diff Detail

Event Timeline

urnathan requested review of this revision.Apr 29 2021, 6:25 AM
urnathan created this revision.
bruno accepted this revision.Apr 29 2021, 3:28 PM

Thanks for keeping a good track of these hacks. Nitpick: before landing, use single instead of double spaces before a new sentence in the comments. LGTM.

This revision is now accepted and ready to land.Apr 29 2021, 3:28 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2021, 9:29 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript