Page MenuHomePhabricator

[gwp_asan] Use __sanitizer_fast_backtrace on Fuchsia
ClosedPublic

Authored by mcgrathr on Apr 27 2021, 3:43 PM.

Diff Detail

Event Timeline

mcgrathr requested review of this revision.Apr 27 2021, 3:43 PM
mcgrathr created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2021, 3:43 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
cryptoad accepted this revision.Apr 27 2021, 3:50 PM
cryptoad added a subscriber: hctim.

Adding @hctim for visibility.

compiler-rt/lib/gwp_asan/optional/backtrace_fuchsia.cpp
16–22

I am not sure I understand the sentence (might be my English skills), should this be provides?

This revision is now accepted and ready to land.Apr 27 2021, 3:50 PM
hctim accepted this revision.Apr 27 2021, 4:13 PM

LGTM with Kostya's nit. Glad to see that the modularity works for Fuchsia out of the box :).

phosek accepted this revision.Apr 27 2021, 7:34 PM

LGTM

mcgrathr marked an inline comment as done.Apr 28 2021, 4:46 PM
mcgrathr added inline comments.
compiler-rt/lib/gwp_asan/optional/backtrace_fuchsia.cpp
16–22

Yes, it was just a typo. Thanks.

mcgrathr updated this revision to Diff 341354.Apr 28 2021, 4:46 PM
mcgrathr marked an inline comment as done.

typo fix

This revision was landed with ongoing or failed builds.Apr 28 2021, 4:48 PM
This revision was automatically updated to reflect the committed changes.