Page MenuHomePhabricator

[mips][microMIPS] Implement SB, SBE, SCE, SH and SHE instructions
AbandonedPublic

Authored by atanasyan on May 29 2015, 4:18 AM.

Diff Detail

Event Timeline

zoran.jovanovic retitled this revision from to [mips][microMIPS] Implement SB, SBE, SCE, SH and SHE instructions.
zoran.jovanovic updated this object.
zoran.jovanovic edited the test plan for this revision. (Show Details)
zoran.jovanovic added reviewers: jkolek, dsanders.
zoran.jovanovic added a subscriber: Unknown Object (MLST).
jkolek edited edge metadata.May 29 2015, 7:30 AM

LGTM with a few nits.

lib/Target/Mips/Disassembler/MipsDisassembler.cpp
255

Align the parameters.

1136

Align the parameters.

lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp
771

Here too, align the parameters.

lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.h
177

Here too, align the parameters.

sdardis resigned from this revision.Apr 14 2016, 6:39 AM
sdardis removed a reviewer: sdardis.
dsanders resigned from this revision.Jul 12 2019, 4:14 PM
atanasyan commandeered this revision.Jul 12 2019, 10:53 PM
atanasyan abandoned this revision.
atanasyan added a reviewer: zoran.jovanovic.

Implemented at the rL246999.