This is an archive of the discontinued LLVM Phabricator instance.

[Docs] Updated the content of getting started documentation under llvm/lib/MC
ClosedPublic

Authored by pooja2299 on Apr 22 2021, 4:20 AM.

Diff Detail

Event Timeline

pooja2299 requested review of this revision.Apr 22 2021, 4:20 AM
pooja2299 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2021, 4:20 AM
pooja2299 retitled this revision from Updated the content of getting started documentation under llv/lib/MC to [Docs] Updated the content of getting started documentation under llvm/lib/MC .Apr 22 2021, 4:31 AM
pooja2299 edited the summary of this revision. (Show Details)

Updated changes in GettingStarted.rst

xgupta accepted this revision.Apr 22 2021, 10:09 AM

LGTM, Thanks for the patch.

This revision is now accepted and ready to land.Apr 22 2021, 10:09 AM

I added @arsenm as the second reviewer, If he thinks the patch looks good, we will commit it.

arsenm added inline comments.Apr 22 2021, 12:11 PM
llvm/docs/GettingStarted.rst
887–888

Saying it translates implies it’s just the assembler and disassembler. It normally directly emits object files

pooja2299 updated this revision to Diff 339963.Apr 23 2021, 3:16 AM

Changed the statement that said 'translation of machine instruction, which suggested that it is just assembler or disassembler.

pooja2299 updated this revision to Diff 340081.Apr 23 2021, 9:29 AM
pooja2299 edited the summary of this revision. (Show Details)

updated llvm/lib/MC section

pooja2299 requested review of this revision.Apr 23 2021, 9:32 AM

@arsenm Plse review it now.

arsenm accepted this revision.Apr 23 2021, 9:34 AM
arsenm added inline comments.
llvm/docs/GettingStarted.rst
887

object and text?

This revision is now accepted and ready to land.Apr 23 2021, 9:34 AM
pooja2299 added a comment.EditedApr 23 2021, 10:00 AM

I didn't understand, can u elaborate plse @arsenm . Does it produce text file as well? it helps in object code emission?

I didn't understand, can u elaborate plse @arsenm . Does it produce text file as well? it helps in object code emission?

It does both. It's everything related to the presentation and consumption of machine encoding, text and binary

I didn't understand, can u elaborate plse @arsenm . Does it produce text file as well? it helps in object code emission?

It does both. It's everything related to the presentation and consumption of machine encoding, text and binary

ok i will update this

some more changes to MC section

pooja2299 retitled this revision from [Docs] Updated the content of getting started documentation under llvm/lib/MC to [Docs] Updated the content of getting started documentation under llvm/lib/MC.

redited lib/MC section

pooja2299 added a comment.EditedApr 28 2021, 1:49 PM

@arsenm Can u please review the patch again and give your feedback?

xgupta added a comment.May 5 2021, 9:49 AM

Assuming all comment addresses I will commit this patch on your behalf @pooja2299.

arsenm added inline comments.May 5 2021, 2:12 PM
llvm/docs/GettingStarted.rst
887–888

"It produces machine code object file" sounds grammatically off. files? This also stopped referencing the text assembly emission

pooja2299 updated this revision to Diff 343313.May 6 2021, 12:32 AM

Updated changes.

@arsenm should I change something else or is it fine?

I think you can copy-paste from here https://llvm.org/docs/CodeGenerator.html#the-mc-layer.

Read a little about this layer under MCInst section here: https://eli.thegreenplace.net/2012/11/24/life-of-an-instruction-in-llvm
MC layer handles the object-file emission (it can also emit textual assembly files).

xgupta resigned from this revision.EditedMay 12 2021, 9:46 AM

I am really not an idol reviewer for this patch.

xgupta added a subscriber: xgupta.May 12 2021, 9:50 AM
pooja2299 updated this revision to Diff 347181.May 22 2021, 1:34 AM

Updated with the suggested changes.

xgupta removed a subscriber: xgupta.May 24 2021, 3:09 AM