This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Specify -ccc-install-dir for linux-cross test
ClosedPublic

Authored by phosek on Apr 22 2021, 12:11 AM.

Details

Summary

This avoids test failures where extra files exist in the tree, such
as the standard library built using the runtimes build.

Diff Detail

Event Timeline

phosek requested review of this revision.Apr 22 2021, 12:11 AM
phosek created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2021, 12:11 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay added inline comments.Apr 22 2021, 9:05 AM
clang/test/Driver/linux-cross.cpp
5

Can you add a comment what happens without -ccc-install-dir?

phosek updated this revision to Diff 339716.Apr 22 2021, 10:42 AM
phosek marked an inline comment as done.
MaskRay accepted this revision.Apr 22 2021, 10:47 AM

With a nit

clang/test/Driver/linux-cross.cpp
16

Rather than in some build configuration., just mention the configuration explicitly.

No need to worry the information gets stale, people can dig up the history if the configuration changes.

With some build configuration, future people cannot know and may defensively add -ccc-install-dir everywhere, which is not what we want for these driver tests.

This revision is now accepted and ready to land.Apr 22 2021, 10:47 AM
phosek updated this revision to Diff 339723.Apr 22 2021, 10:57 AM
phosek marked an inline comment as done.
This revision was landed with ongoing or failed builds.Apr 22 2021, 10:58 AM
This revision was automatically updated to reflect the committed changes.