This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] Add C-SKY Support in benchmark 1.3.0
ClosedPublic

Authored by zixuan-wu on Apr 20 2021, 11:48 PM.

Details

Summary

Use gettimeofday to get the number of cycles since power-on in CSKY backend.

Diff Detail

Repository
rT test-suite

Event Timeline

zixuan-wu requested review of this revision.Apr 20 2021, 11:48 PM
zixuan-wu created this revision.
lebedev.ri requested changes to this revision.Apr 21 2021, 12:25 AM

Please can you submit this upstream first?

This revision now requires changes to proceed.Apr 21 2021, 12:25 AM

The same work has been upstreamed at https://github.com/google/benchmark/pull/1400.
And how is this patch going? we need pull latest code to upgrade benchmark or still commit this in llvm-test-suite?
@mtrofin

Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2022, 2:22 AM

The same work has been upstreamed at https://github.com/google/benchmark/pull/1400.
And how is this patch going? we need pull latest code to upgrade benchmark or still commit this in llvm-test-suite?
@mtrofin

It'd be best to pull from upstream, but if that is too big of a change, fine to patch here.

The same work has been upstreamed at https://github.com/google/benchmark/pull/1400.
And how is this patch going? we need pull latest code to upgrade benchmark or still commit this in llvm-test-suite?
@mtrofin

It'd be best to pull from upstream, but if that is too big of a change, fine to patch here.

I think this change is nit, if pull from upstream, the change is big and may cause regression.
Since you processed the last pull merge, could you please process this again, or we just continue to do this patch? I am OK with both solutions.

mtrofin accepted this revision.May 25 2022, 7:56 AM
zixuan-wu updated this revision to Diff 432174.May 25 2022, 7:56 PM
zixuan-wu set the repository for this revision to rT test-suite.May 26 2022, 1:48 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 26 2022, 7:03 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.