[HWASan] Use memory addresses in tag dump, not shadow.

[hctim]

Summary

EOM.

[eugenis]

could you also update the test to check that the invalid access address from the report header matches one of the tag dump addresses?

[hctim]

Add test. Depends on D10112.

[hctim]

• Remove dependency.

[hctim]

• Remove dependency.

[eugenis]

why is this necessary? there should be a memory address in the report header I think

[hctim]

In D100783#2713146, @eugenis wrote:

why is this necessary? there should be a memory address in the report header I think

Yes, but IMO it makes a lot more sense for the shadow dump to be noted with the memory address, not the shadow address. I know that this actually confused me when interpreting a HWASan report, and it makes it more inline with what's possible with MTE.

[eugenis]

I meant why __hwasan_tag_pointer is necessary, can't you match the address in the report header?
But I don't really care that much, LGTM if this is easier for any reason.

compiler-rt/lib/hwasan/hwasan_report.cpp

static void PrintTagInfoAroundAddr(tag_t *tag_ptr, uptr num_rows,
   const uptr row_len = 16;  // better be power of two.
   tag_t *center_row_beg = reinterpret_cast<tag_t *>(
       RoundDownTo(reinterpret_cast<uptr>(tag_ptr), row_len));
   tag_t *beg_row = center_row_beg - row_len * (num_rows / 2);
   tag_t *end_row = center_row_beg + row_len * ((num_rows + 1) / 2);
   InternalScopedString s;
   for (tag_t *row = beg_row; row < end_row; row += row_len) {
     s.append("%s", row == center_row_beg ? "=>" : "  ");
-    s.append("%p:", row);
+    s.append("%p:", ShadowToMem(reinterpret_cast<uptr>(row)));
     for (uptr i = 0; i < row_len; i++) {
       s.append("%s", row + i == tag_ptr ? "[" : " ");
       print_tag(s, &row[i]);
       s.append("%s", row + i == tag_ptr ? "]" : " ");
     }
     s.append("\n");
   }
   Printf("%s", s.data());