EOM.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
could you also update the test to check that the invalid access address from the report header matches one of the tag dump addresses?
Comment Actions
Yes, but IMO it makes a lot more sense for the shadow dump to be noted with the memory address, not the shadow address. I know that this actually confused me when interpreting a HWASan report, and it makes it more inline with what's possible with MTE.
Comment Actions
I meant why __hwasan_tag_pointer is necessary, can't you match the address in the report header?
But I don't really care that much, LGTM if this is easier for any reason.