Diff Detail
Event Timeline
LGTM, But also adding @aqjune as a second reviewer.
Would you please also add the example for Boolean, Float-Point, Null pointer, and Token constant so the Simple Constants section looks complete?
Feel free to ask if you can't find their examples in test cases.
Hi,
Would you explain what this patch is for?
I think add %in, 1 isn't constant... it is an instruction.
Actually, this patch is for adding examples for the simple constants section in Langref.
I'm not sure whether this is a good direction - adding one example for each item might be pretty verbose considering that they are basic constructs.
What about having a code snippet that includes all of these types (including integers) after There are no constants of type x86_mmx.?
+ Adding reviewers who are working as reviewers for LangRef patches
Yeah, this doesn't look particularly useful to me.
Something I'd love to see though is a listing of special values for all floating point types. Always takes me a while to figure out how to test various inf/nan/sz for different float types, with their encoding peculiarities.