Page MenuHomePhabricator

[TableGen] Remove predicate filtering from GenerateVariants.
ClosedPublic

Authored by craig.topper on Fri, Apr 16, 10:23 PM.

Details

Summary

After D100691, predicates should be cheap to compare again so
we don't need to filter anymore.

This is mostly just a revert of several patches going back to 2018.

Diff Detail

Event Timeline

craig.topper requested review of this revision.Fri, Apr 16, 10:23 PM
craig.topper created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFri, Apr 16, 10:24 PM

Add the HwModeFeatures comparison I accidentally removed.

Remove the HwModeFeature check. We're running this before HwMode expansion. Just assert that the string is empty.

Looks ok to me, but waiting for the prerequisite patch to be finalized.

kparzysz accepted this revision.Wed, Apr 28, 12:49 PM
This revision is now accepted and ready to land.Wed, Apr 28, 12:49 PM
This revision was landed with ongoing or failed builds.Wed, Apr 28, 4:02 PM
This revision was automatically updated to reflect the committed changes.