This is an archive of the discontinued LLVM Phabricator instance.

Differential D100693

[scudo] Avoid empty statement warnings
ClosedPublic

Authored by mcgrathr on Apr 16 2021, 7:02 PM.

Details

Reviewers
cryptoad
vitalybuka
hctim
Commits
rGd9b2641aa5f3: [scudo] Avoid empty statement warnings
Summary

An empty macro that expands to just ... else ; can get
warnings from some compilers (e.g. GCC's -Wempty-body).

Diff Detail

Event Timeline

mcgrathr requested review of this revision.Apr 16 2021, 7:02 PM
mcgrathr created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2021, 7:02 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
cryptoad accepted this revision.Apr 16 2021, 7:11 PM

Well I wrote up https://reviews.llvm.org/D100683, but I guess yours makes more sense!

This revision is now accepted and ready to land.Apr 16 2021, 7:11 PM
Harbormaster completed remote builds in B99291: Diff 338268.Apr 16 2021, 7:51 PM
vitalybuka accepted this revision.Apr 16 2021, 10:17 PM
vitalybuka mentioned this in D100683: [scudo][standalone] Fix -Werror=empty-body error on Fuchsia.Apr 16 2021, 10:19 PM
Closed by commit rGd9b2641aa5f3: [scudo] Avoid empty statement warnings (authored by mcgrathr). · Explain WhyApr 21 2021, 12:39 PM
This revision was automatically updated to reflect the committed changes.
mcgrathr added a commit: rGd9b2641aa5f3: [scudo] Avoid empty statement warnings.

Revision Contents

PathSize
compiler-rt/
lib/
scudo/
standalone/
28 lines

Diff 339352

compiler-rt/lib/scudo/standalone/internal_defs.h

Show First 20 Lines • Show All 100 Lines • ▼ Show 20 Lines
#define DCHECK(A) CHECK(A) #define DCHECK(A) CHECK(A)
#define DCHECK_EQ(A, B) CHECK_EQ(A, B) #define DCHECK_EQ(A, B) CHECK_EQ(A, B)
#define DCHECK_NE(A, B) CHECK_NE(A, B) #define DCHECK_NE(A, B) CHECK_NE(A, B)
#define DCHECK_LT(A, B) CHECK_LT(A, B) #define DCHECK_LT(A, B) CHECK_LT(A, B)
#define DCHECK_LE(A, B) CHECK_LE(A, B) #define DCHECK_LE(A, B) CHECK_LE(A, B)
#define DCHECK_GT(A, B) CHECK_GT(A, B) #define DCHECK_GT(A, B) CHECK_GT(A, B)
#define DCHECK_GE(A, B) CHECK_GE(A, B) #define DCHECK_GE(A, B) CHECK_GE(A, B)
#else #else
#define DCHECK(A) #define DCHECK(A) \
#define DCHECK_EQ(A, B) do { \
#define DCHECK_NE(A, B) } while (false)
#define DCHECK_LT(A, B) #define DCHECK_EQ(A, B) \
#define DCHECK_LE(A, B) do { \
#define DCHECK_GT(A, B) } while (false)
#define DCHECK_GE(A, B) #define DCHECK_NE(A, B) \
do { \
} while (false)
#define DCHECK_LT(A, B) \
do { \
} while (false)
#define DCHECK_LE(A, B) \
do { \
} while (false)
#define DCHECK_GT(A, B) \
do { \
} while (false)
#define DCHECK_GE(A, B) \
do { \
} while (false)
#endif #endif
// The superfluous die() call effectively makes this macro NORETURN. // The superfluous die() call effectively makes this macro NORETURN.
#define UNREACHABLE(Msg) \ #define UNREACHABLE(Msg) \
do { \ do { \
CHECK(0 && Msg); \ CHECK(0 && Msg); \
die(); \ die(); \
} while (0) } while (0)
} // namespace scudo } // namespace scudo
#endif // SCUDO_INTERNAL_DEFS_H_ #endif // SCUDO_INTERNAL_DEFS_H_