Page MenuHomePhabricator

[lld-link] Warn on exported deleting dtor
ClosedPublic

Authored by zequanwu on Thu, Apr 15, 4:25 PM.

Details

Summary

MSVC linker has this warning, so lld-link should also warn on this.

Diff Detail

Event Timeline

zequanwu requested review of this revision.Thu, Apr 15, 4:25 PM
zequanwu created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptThu, Apr 15, 4:25 PM
rnk added a comment.Fri, Apr 16, 3:31 PM

Seems reasonable, but I see harbormaster test failures.

zequanwu updated this revision to Diff 338269.Fri, Apr 16, 7:05 PM

Update testcase.

rnk added a comment.Mon, Apr 19, 1:54 PM

Seems reasonable, but I see harbormaster test failures.

The export.test seems to be crashing still both on Debian and Windows. Do you see that locally? Maybe it needs assertions to be enabled/disabled?

zequanwu updated this revision to Diff 338658.Mon, Apr 19, 3:27 PM
  • Check e.sym for null. If the flag /export=foo is provided and foo is not in the object file. e.sym will be null.
  • Remove $ in exported name to have same name on windows and linux.
rnk accepted this revision.Tue, Apr 20, 12:57 PM

lgtm

This revision is now accepted and ready to land.Tue, Apr 20, 12:57 PM
This revision was automatically updated to reflect the committed changes.