This is an archive of the discontinued LLVM Phabricator instance.

Differential D100434

[llvm-symbolizer] remove unused variable
ClosedPublic

Authored by thakis on Apr 13 2021, 7:04 PM.

Details

Reviewers
MaskRay
jhenderson
Commits
rG7a9cb801f3e7: [llvm-symbolizer] remove unused variable
Summary

This should've been removed in D83530.

Diff Detail

Event Timeline

thakis created this revision.Apr 13 2021, 7:04 PM
Herald added a reviewer: jhenderson. · View Herald TranscriptApr 13 2021, 7:04 PM
Herald added a subscriber: rupprecht. · View Herald Transcript
thakis requested review of this revision.Apr 13 2021, 7:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2021, 7:04 PM
MaskRay accepted this revision.Apr 13 2021, 7:48 PM

LGTM.

This revision is now accepted and ready to land.Apr 13 2021, 7:48 PM
Harbormaster completed remote builds in B98592: Diff 337309.Apr 13 2021, 10:49 PM
Closed by commit rG7a9cb801f3e7: [llvm-symbolizer] remove unused variable (authored by thakis). · Explain WhyApr 14 2021, 6:31 AM
This revision was automatically updated to reflect the committed changes.
thakis added a commit: rG7a9cb801f3e7: [llvm-symbolizer] remove unused variable.

Revision Contents

PathSize
llvm/
tools/
llvm-symbolizer/
4 lines

Diff 337435

llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines
}; };
class SymbolizerOptTable : public opt::OptTable { class SymbolizerOptTable : public opt::OptTable {
public: public:
SymbolizerOptTable() : OptTable(InfoTable, true) {} SymbolizerOptTable() : OptTable(InfoTable, true) {}
}; };
} // namespace } // namespace
static cl::list<std::string> ClInputAddresses(cl::Positional,
cl::desc("<input addresses>..."),
cl::ZeroOrMore);
template <typename T> template <typename T>
static void print(const Request &Request, Expected<T> &ResOrErr, static void print(const Request &Request, Expected<T> &ResOrErr,
DIPrinter &Printer) { DIPrinter &Printer) {
if (ResOrErr) { if (ResOrErr) {
// No error, print the result. // No error, print the result.
Printer.print(Request, *ResOrErr); Printer.print(Request, *ResOrErr);
return; return;
} }
▲ Show 20 Lines • Show All 275 Lines • Show Last 20 Lines