This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Make the findVCToolChainViaEnvironment case-insensitive
ClosedPublic

Authored by ArturGainullin on Apr 12 2021, 10:28 PM.

Details

Summary

PATH usage on Windows is case-insensitive. There could be situations
when toolchain path can't be obtained from PATH because of
case-sensitivity of the findVCToolChainViaEnvironment.

Diff Detail

Event Timeline

ArturGainullin requested review of this revision.Apr 12 2021, 10:28 PM
ArturGainullin created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2021, 10:28 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rnk accepted this revision.Apr 13 2021, 1:21 PM

lgtm

This code could greatly benefit from some unit tests similar in style to the GCC installation detection tests, but It would be unreasonable for me to insist on them.

This revision is now accepted and ready to land.Apr 13 2021, 1:21 PM

Thank you for the example! I will take a look and may consider adding a test as a follow up commit.