Page MenuHomePhabricator

Support: Avoid unnecessary std::function for SignpostEmitterImpl::SignpostLog
ClosedPublic

Authored by dexonsmith on Apr 8 2021, 4:21 PM.

Details

Summary

The destructor for SignPostEmitterImpl::SignpostLog is known statically. Avoid
the unnecessary vtable indirection through std::function in the std::unique_ptr
by turning LogDeleter into a struct. No real functionality change here.

Diff Detail

Event Timeline

dexonsmith created this revision.Apr 8 2021, 4:21 PM
dexonsmith requested review of this revision.Apr 8 2021, 4:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2021, 4:21 PM
dsanders accepted this revision.Apr 8 2021, 4:32 PM

LGTM

This revision is now accepted and ready to land.Apr 8 2021, 4:32 PM
This revision was landed with ongoing or failed builds.Apr 8 2021, 4:35 PM
This revision was automatically updated to reflect the committed changes.