This is an archive of the discontinued LLVM Phabricator instance.

Differential D100087

Include `count` in AppleClang toolchains.
ClosedPublic

Authored by delcypher on Apr 7 2021, 9:37 PM.

Details

Reviewers
arphaman
JDevlieghere
Commits
rGf66e05a720f7: Include `count` in AppleClang toolchains.
Summary

The motivation here is so we can run the compiler-rt tests
from a standalone build against AppleClang.

In particular the Posix/halt_on_error-torture.cpp and
Posix/halt_on_error_suppress_equal_pcs.cpp ASan test cases currently
require this binary for the tests to pass.

rdar://76366784

Diff Detail

Event Timeline

delcypher created this revision.Apr 7 2021, 9:37 PM
Herald added a subscriber: mgorny. · View Herald TranscriptApr 7 2021, 9:37 PM
delcypher requested review of this revision.Apr 7 2021, 9:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2021, 9:38 PM
Harbormaster completed remote builds in B97649: Diff 335997.Apr 7 2021, 10:08 PM
arphaman accepted this revision.Apr 8 2021, 1:02 PM
This revision is now accepted and ready to land.Apr 8 2021, 1:02 PM
Closed by commit rGf66e05a720f7: Include `count` in AppleClang toolchains. (authored by delcypher). · Explain WhyApr 8 2021, 2:00 PM
This revision was automatically updated to reflect the committed changes.
delcypher added a commit: rGf66e05a720f7: Include `count` in AppleClang toolchains..

Revision Contents

PathSize
clang/
cmake/
caches/
1 line

Diff 336217

clang/cmake/caches/Apple-stage2.cmake

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Linesset(LLVM_TOOLCHAIN_TOOLS
CACHE STRING "") CACHE STRING "")
set(LLVM_BUILD_UTILS ON CACHE BOOL "") set(LLVM_BUILD_UTILS ON CACHE BOOL "")
set(LLVM_INSTALL_UTILS ON CACHE BOOL "") set(LLVM_INSTALL_UTILS ON CACHE BOOL "")
set(LLVM_TOOLCHAIN_UTILITIES set(LLVM_TOOLCHAIN_UTILITIES
FileCheck FileCheck
yaml2obj yaml2obj
not not
count
CACHE STRING "") CACHE STRING "")
set(LLVM_DISTRIBUTION_COMPONENTS set(LLVM_DISTRIBUTION_COMPONENTS
clang clang
LTO LTO
clang-format clang-format
clang-resource-headers clang-resource-headers
cxx-headers cxx-headers
Remarks Remarks
${LLVM_TOOLCHAIN_TOOLS} ${LLVM_TOOLCHAIN_TOOLS}
${LLVM_TOOLCHAIN_UTILITIES} ${LLVM_TOOLCHAIN_UTILITIES}
CACHE STRING "") CACHE STRING "")
# test args # test args
set(LLVM_LIT_ARGS "--xunit-xml-output=testresults.xunit.xml -v" CACHE STRING "") set(LLVM_LIT_ARGS "--xunit-xml-output=testresults.xunit.xml -v" CACHE STRING "")