This is an archive of the discontinued LLVM Phabricator instance.

Differential D100082

[lld-macho][nfc] Extend abs-symbol.s to test for local absolute symbols
ClosedPublic

Authored by int3 on Apr 7 2021, 7:33 PM.

Details

Reviewers
oontvoo
Group Reviewers
Restricted Project
Commits
rG3f6753efe199: [lld-macho][nfc] Extend abs-symbol.s to test for local absolute symbols
Summary

Addresses an old TODO.

Diff Detail

Event Timeline

int3 created this revision.Apr 7 2021, 7:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2021, 7:33 PM
int3 requested review of this revision.Apr 7 2021, 7:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2021, 7:33 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
oontvoo accepted this revision.Apr 7 2021, 7:40 PM
oontvoo added a subscriber: oontvoo.

LGTM

This revision is now accepted and ready to land.Apr 7 2021, 7:40 PM
Harbormaster completed remote builds in B97636: Diff 335976.Apr 7 2021, 8:13 PM
Closed by commit rG3f6753efe199: [lld-macho][nfc] Extend abs-symbol.s to test for local absolute symbols (authored by int3). · Explain WhyApr 8 2021, 9:21 AM
This revision was automatically updated to reflect the committed changes.
int3 added a commit: rG3f6753efe199: [lld-macho][nfc] Extend abs-symbol.s to test for local absolute symbols.

Revision Contents

PathSize
lld/
test/
MachO/
5 lines

Diff 336147

lld/test/MachO/abs-symbols.s

# REQUIRES: x86 # REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t.o # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t.o
# RUN: %lld -lSystem %t.o -o %t # RUN: %lld -lSystem %t.o -o %t
# RUN: llvm-objdump --macho --syms --exports-trie %t | FileCheck %s # RUN: llvm-objdump --macho --syms --exports-trie %t | FileCheck %s
# CHECK-LABEL: SYMBOL TABLE: # CHECK-LABEL: SYMBOL TABLE:
# CHECK-DAG: 000000000000dead g *ABS* _foo # CHECK-DAG: 000000000000dead g *ABS* _foo
# CHECK-DAG: 000000000000beef g *ABS* _weakfoo # CHECK-DAG: 000000000000beef g *ABS* _weakfoo
# CHECK-DAG: 000000000000cafe l *ABS* _localfoo
# CHECK-LABEL: Exports trie: # CHECK-LABEL: Exports trie:
# CHECK-DAG: 0x0000DEAD _foo [absolute] # CHECK-DAG: 0x0000DEAD _foo [absolute]
# CHECK-DAG: 0x0000BEEF _weakfoo [absolute] # CHECK-DAG: 0x0000BEEF _weakfoo [absolute]
.globl _foo, _weakfoo, _main .globl _foo, _weakfoo, _main
.weak_definition _weakfoo .weak_definition _weakfoo
_foo = 0xdead _foo = 0xdead
_weakfoo = 0xbeef _weakfoo = 0xbeef
_localfoo = 0xcafe
.text .text
_main: _main:
ret ret
## TODO: once we support emitting local symbols in the symtab, test local
## absolute symbols too