Page MenuHomePhabricator

Add csum fallback to HashProgramOutput.sh
ClosedPublic

Authored by daltenty on Apr 7 2021, 3:18 PM.

Details

Summary

On AIX we don't have either md5 or md5sum on a default install, but we can use csum instead for equivalent functionality.

Diff Detail

Repository
rT test-suite

Event Timeline

daltenty requested review of this revision.Apr 7 2021, 3:18 PM
daltenty created this revision.
daltenty updated this revision to Diff 336078.Apr 8 2021, 6:14 AM
  • Fix typo
daltenty updated this revision to Diff 336169.Apr 8 2021, 10:54 AM
  • Correct the options we pass to csum
stevewan accepted this revision.Apr 8 2021, 1:27 PM

LGTM with minor nit.

HashProgramOutput.sh
9

nit: Having is_md5sum=1 for csum is somewhat counter-intuitive, maybe rename this is_md5 and reverse the value?

This revision is now accepted and ready to land.Apr 8 2021, 1:27 PM
stevewan added inline comments.Apr 8 2021, 1:31 PM
HashProgramOutput.sh
21

csum defaults to using the MD5 algorithm for both generating and verifying message digests, but I'm okay with being explicit here.

daltenty updated this revision to Diff 336230.Apr 8 2021, 2:19 PM
  • Change is_md5sum to is_md5
This revision was automatically updated to reflect the committed changes.