Refactor: Simplify boolean expressions in tools/llvm-objdump

[LegalizeAdulthood]

Summary

Use clang-tidy to simplify boolean expressions

[• rafael]

LGTM

[LegalizeAdulthood]

Update to latest.
I do not have commit access.

[LegalizeAdulthood]

I do not have commit access, so someone else will need to commit this. Let me know if it needs rebasing.

Patch by Richard Thomson.

[LegalizeAdulthood]

Discarding due to inaction by reviewers.

tools/llvm-objdump/MachODump.cpp

if (n_value != 0) {
     if (cro.baseProperties != 0)
       outs() << " + " << format("0x%" PRIx64, cro.baseProperties);
   } else
     outs() << format("0x%" PRIx64, cro.baseProperties);
   outs() << "\n";
   if (cro.baseProperties + n_value != 0)
     print_objc_property_list64(cro.baseProperties + n_value, info);
 
-  is_meta_class = (cro.flags & RO_META) ? true : false;
+  is_meta_class = cro.flags & RO_META;
 }
 
 static void print_class_ro32_t(uint32_t p, struct DisassembleInfo *info,
                                bool &is_meta_class) {
   struct class_ro32_t cro;
   const char *r;
   uint32_t offset, xoffset, left;
   SectionRef S, xS;
if (cro.ivars != 0)
     print_ivar_list32_t(cro.ivars, info);
   outs() << "           weakIvarLayout "
          << format("0x%" PRIx32, cro.weakIvarLayout) << "\n";
   print_layout_map32(cro.weakIvarLayout, info);
   outs() << "           baseProperties "
          << format("0x%" PRIx32, cro.baseProperties) << "\n";
   if (cro.baseProperties != 0)
     print_objc_property_list32(cro.baseProperties, info);
-  is_meta_class = (cro.flags & RO_META) ? true : false;
+  is_meta_class = cro.flags & RO_META;
 }
 
 static void print_class64_t(uint64_t p, struct DisassembleInfo *info) {
   struct class64_t c;
   const char *r;
   uint32_t offset, left;
   SectionRef S;
   const char *name;
static void print_class64_t(uint64_t p, struct DisassembleInfo *info) {
 
   // This is a Swift class if some of the low bits of the pointer are set.
   if ((c.data + n_value) & 0x7)
     outs() << " Swift class";
   outs() << "\n";
   bool is_meta_class;
   print_class_ro64_t((c.data + n_value) & ~0x7, info, is_meta_class);
 
-  if (is_meta_class == false) {
+  if (!is_meta_class) {
     outs() << "Meta Class\n";
     print_class64_t(c.isa + isa_n_value, info);
   }
 }
 
 static void print_class32_t(uint32_t p, struct DisassembleInfo *info) {
   struct class32_t c;
   const char *r;
static void print_class32_t(uint32_t p, struct DisassembleInfo *info) {
 
   // This is a Swift class if some of the low bits of the pointer are set.
   if (c.data & 0x3)
     outs() << " Swift class";
   outs() << "\n";
   bool is_meta_class;
   print_class_ro32_t(c.data & ~0x3, info, is_meta_class);
 
-  if (is_meta_class == false) {
+  if (!is_meta_class) {
     outs() << "Meta Class\n";
     print_class32_t(c.isa, info);
   }
 }
 
 static void print_objc_class_t(struct objc_class_t *objc_class,
                                struct DisassembleInfo *info) {
   uint32_t offset, left, xleft;
else {
     if (H.cputype == MachO::CPU_TYPE_ARM)
       printObjc2_32bit_MetaData(O, verbose);
     else {
       // This is the 32-bit non-arm cputype case.  Which is normally
       // the first Objective-C ABI.  But it may be the case of a
       // binary for the iOS simulator which is the second Objective-C
       // ABI.  In that case printObjc1_32bit_MetaData() will determine that
       // and return false.
-      if (printObjc1_32bit_MetaData(O, verbose) == false)
+      if (!printObjc1_32bit_MetaData(O, verbose))
         printObjc2_32bit_MetaData(O, verbose);
     }
   }
 }
 
 // GuessLiteralPointer returns a string which for the item in the Mach-O file
 // for the address passed in as ReferenceValue for printing as a comment with
 // the instruction and also returns the corresponding type of that item