Page MenuHomePhabricator

[Driver][test] Test intended target only
ClosedPublic

Authored by jsji on Mon, Apr 5, 2:43 PM.

Details

Summary

6fe7de90b9e4e466a5c2baadafd5f72d3203651d changed GNU toolchain,
and added new RUN line to test expected behavior.

The change is for GNU toolchain only, so this will fail other toolchain,
eg: AIX.

Update the test with -target to test GNU tool chain only.

Diff Detail

Event Timeline

jsji requested review of this revision.Mon, Apr 5, 2:43 PM
jsji created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMon, Apr 5, 2:43 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay added inline comments.Mon, Apr 5, 11:01 PM
clang/test/Driver/nostdincxx.cpp
4

error: unknown target triple 'unknown-unknown-hurd-gnu', please use -triple or -arch

Perhaps this should UNSUPPORTED aix if aix does not support -nostdinc++.

jsji updated this revision to Diff 335499.Tue, Apr 6, 6:39 AM

Use -arch instead

clang/test/Driver/nostdincxx.cpp
4

No, AIX does support -nostdinc++, we don't want to unsupport this whole test

jsji updated this revision to Diff 335500.Tue, Apr 6, 6:40 AM

Remove typo.

MaskRay accepted this revision.Wed, Apr 7, 11:13 AM
This revision is now accepted and ready to land.Wed, Apr 7, 11:13 AM
This revision was automatically updated to reflect the committed changes.